Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide site elements if render in iframe #1409

Merged
merged 2 commits into from
Aug 14, 2024
Merged

Hide site elements if render in iframe #1409

merged 2 commits into from
Aug 14, 2024

Conversation

VladyslavTy
Copy link

Change description

We need to hide the elements like header, footer, nav panel if the site is rendered in iframe. These changes is a part of Seertech IDP integration for Snowflake customer. ENG-714

Added event listener that check if the site is render in iframe.
If yes - add the display: none !important; to the styles of choosen elements by their className classesToHide
If no - nothing changes

Type of change

  • Bug fix (fixes an issue)
  • New feature (adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • Application changes have been tested thoroughly
  • Automated tests covering modified code pass

Security

  • Security impact of change has been considered
  • Code follows company security practices and guidelines

Code review

  • Pull request has a descriptive title and context useful to a reviewer. Screenshots or screencasts are attached as necessary
  • "Ready for review" label attached and reviewers assigned
  • Changes have been reviewed by at least one other contributor
  • Pull request linked to task tracker where applicable

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
jfaMan
jfaMan requested changes Aug 14, 2024
View reviewed changes
common/static/js/src/iframe-render.js Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link

Checking git merge conflicts against https://github.com/openedx/edx-platform.git

Comparing with open-release/nutmeg.master
Benchmark conflicts with main 301
Current conflicts 302
Summary Adds 1 new conflicts. How can we do better?
New conflicting files with 'open-release/nutmeg.master' 
lms/static/sass/shared-v2/_base.scss
lms/templates/main.html
Comparing with master
Benchmark conflicts with main 331
Current conflicts 332
Summary Adds 1 new conflicts. How can we do better?
New conflicting files with 'master' 
lms/static/sass/shared-v2/_base.scss
lms/templates/main.html

@VladyslavTy VladyslavTy merged commit 6290527 into main Aug 14, 2024
11 checks passed
@VladyslavTy VladyslavTy deleted the vladyslav/hide-html-elements-in-iframe branch August 14, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniilly daniilly daniilly approved these changes

@jfaMan jfaMan jfaMan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VladyslavTy @jfaMan @daniilly